src/main/kotlin/platform/mixin/inspection/StaticMemberInspection.kt diff

← → edited src/main/kotlin/platform/mixin/inspection/StaticMemberInspection.kt

Ignore whitespaces Open in IDE

⁠ kyle wood: Fix up all duplicaate code warnings

Also messed up the ktlint configuration trying to upgrade it, but future
versions are still a broken mess. Sorry about that.

Copy Copy

/*
* Minecraft Dev for IntelliJ
*
* https://minecraftdev.org
*
* Copyright (c) 2023 minecraft-dev
*
* MIT License
*/

package com.demonwav.mcdev.platform.mixin.inspection

import com.demonwav.mcdev.platform.mixin.util.MixinConstants.Annotations.ACCESSOR
import com.demonwav.mcdev.platform.mixin.util.MixinConstants.Annotations.INVOKER
import com.demonwav.mcdev.platform.mixin.util.MixinConstants.Annotations.OVERWRITE
import com.demonwav.mcdev.platform.mixin.util.MixinConstants.Annotations.SHADOW
import com.demonwav.mcdev.platform.mixin.util.isMixin
import com.intellij.codeInsight.intention.QuickFixFactory
import com.intellij.codeInspection.ProblemsHolder
import com.intellij.psi.JavaElementVisitor
import com.intellij.psi.PsiElementVisitor
import com.intellij.psi.PsiField
import com.intellij.psi.PsiMember
import com.intellij.psi.PsiMethod
import com.intellij.psi.PsiModifier

class StaticMemberInspection : MixinInspection() {

override fun getStaticDescription() =
"A mixin class does not exist at runtime, and thus having them public does not make sense. " +
"Make the field/method private instead."

override fun buildVisitor(holder: ProblemsHolder): PsiElementVisitor = Visitor(holder)

private class Visitor(private val holder: ProblemsHolder) : JavaElementVisitor() {

override fun visitMethod(method: PsiMethod) {
visitMember(method)
}

override fun visitField(field: PsiField) {
visitMember(field)
}

private fun visitMember(member: PsiMember) {
if (isProblematic(member)) {
holder.registerProblem(
member,
"Public static members are not allowed in Mixin classes",
QuickFixFactory.getInstance().createModifierListFix(member, PsiModifier.PRIVATE, true, false)
)
}
}

private fun isProblematic(member: PsiMember): Boolean {
val containingClass = member.containingClass ?: return false
if (!containingClass.isMixin) {
return false
}

val modifiers = member.modifierList!!

return modifiers.hasModifierProperty(PsiModifier.PUBLIC) &&
modifiers.hasModifierProperty(PsiModifier.STATIC) &&
modifiers.findAnnotation(SHADOW) == null &&
modifiers.findAnnotation(OVERWRITE) == null &&
modifiers.findAnnotation(ACCESSOR) == null &&
modifiers.findAnnotation(INVOKER) == null
}
}
}

/*
* Minecraft Dev for IntelliJ
*
* https://minecraftdev.org
*
* Copyright (c) 2023 minecraft-dev
*
* MIT License
*/

package com.demonwav.mcdev.platform.mixin.inspection

import com.demonwav.mcdev.platform.mixin.util.MixinConstants.Annotations.ACCESSOR
import com.demonwav.mcdev.platform.mixin.util.MixinConstants.Annotations.INVOKER
import com.demonwav.mcdev.platform.mixin.util.MixinConstants.Annotations.OVERWRITE
import com.demonwav.mcdev.platform.mixin.util.MixinConstants.Annotations.SHADOW
import com.demonwav.mcdev.platform.mixin.util.isMixin
import com.intellij.codeInsight.intention.QuickFixFactory
import com.intellij.codeInspection.ProblemsHolder
import com.intellij.psi.JavaElementVisitor
import com.intellij.psi.PsiElementVisitor
import com.intellij.psi.PsiField
import com.intellij.psi.PsiMember
import com.intellij.psi.PsiMethod
import com.intellij.psi.PsiModifier

class StaticMemberInspection : MixinInspection() {

override fun getStaticDescription() =
"A mixin class does not exist at runtime, and thus having them public does not make sense. " +
"Make the field/method private instead."

override fun buildVisitor(holder: ProblemsHolder): PsiElementVisitor = Visitor(holder)

private class Visitor(private val holder: ProblemsHolder) : JavaElementVisitor() {

override fun visitMethod(method: PsiMethod) {
visitMember(method)
}

override fun visitField(field: PsiField) {
visitMember(field)
}

private fun visitMember(member: PsiMember) {
if (isProblematic(member)) {
holder.registerProblem(
member,
"Public static members are not allowed in Mixin classes",
QuickFixFactory.getInstance().createModifierListFix(member, PsiModifier.PRIVATE, true, false),
)
}
}

private fun isProblematic(member: PsiMember): Boolean {
val containingClass = member.containingClass ?: return false
if (!containingClass.isMixin) {
return false
}

val modifiers = member.modifierList!!

return modifiers.hasModifierProperty(PsiModifier.PUBLIC) &&
modifiers.hasModifierProperty(PsiModifier.STATIC) &&
modifiers.findAnnotation(SHADOW) == null &&
modifiers.findAnnotation(OVERWRITE) == null &&
modifiers.findAnnotation(ACCESSOR) == null &&
modifiers.findAnnotation(INVOKER) == null
}
}
}

/* * Minecraft Dev for IntelliJ * * https://minecraftdev.org * * Copyright (c) 2023 minecraft-dev * * MIT License */ package com.demonwav.mcdev.platform.mixin.inspection import com.demonwav.mcdev.platform.mixin.util.MixinConstants.Annotations.ACCESSOR import com.demonwav.mcdev.platform.mixin.util.MixinConstants.Annotations.INVOKER import com.demonwav.mcdev.platform.mixin.util.MixinConstants.Annotations.OVERWRITE import com.demonwav.mcdev.platform.mixin.util.MixinConstants.Annotations.SHADOW import com.demonwav.mcdev.platform.mixin.util.isMixin import com.intellij.codeInsight.intention.QuickFixFactory import com.intellij.codeInspection.ProblemsHolder import com.intellij.psi.JavaElementVisitor import com.intellij.psi.PsiElementVisitor import com.intellij.psi.PsiField import com.intellij.psi.PsiMember import com.intellij.psi.PsiMethod import com.intellij.psi.PsiModifier class StaticMemberInspection : MixinInspection() { override fun getStaticDescription() = "A mixin class does not exist at runtime, and thus having them public does not make sense. " + "Make the field/method private instead." override fun buildVisitor(holder: ProblemsHolder): PsiElementVisitor = Visitor(holder) private class Visitor(private val holder: ProblemsHolder) : JavaElementVisitor() { override fun visitMethod(method: PsiMethod) { visitMember(method) } override fun visitField(field: PsiField) { visitMember(field) } private fun visitMember(member: PsiMember) { if (isProblematic(member)) { holder.registerProblem( member, "Public static members are not allowed in Mixin classes", QuickFixFactory.getInstance().createModifierListFix(member, PsiModifier.PRIVATE, true, false) ) } } private fun isProblematic(member: PsiMember): Boolean { val containingClass = member.containingClass ?: return false if (!containingClass.isMixin) { return false } val modifiers = member.modifierList!! return modifiers.hasModifierProperty(PsiModifier.PUBLIC) && modifiers.hasModifierProperty(PsiModifier.STATIC) && modifiers.findAnnotation(SHADOW) == null && modifiers.findAnnotation(OVERWRITE) == null && modifiers.findAnnotation(ACCESSOR) == null && modifiers.findAnnotation(INVOKER) == null } } } /* * Minecraft Dev for IntelliJ * * https://minecraftdev.org * * Copyright (c) 2023 minecraft-dev * * MIT License */ package com.demonwav.mcdev.platform.mixin.inspection import com.demonwav.mcdev.platform.mixin.util.MixinConstants.Annotations.ACCESSOR import com.demonwav.mcdev.platform.mixin.util.MixinConstants.Annotations.INVOKER import com.demonwav.mcdev.platform.mixin.util.MixinConstants.Annotations.OVERWRITE import com.demonwav.mcdev.platform.mixin.util.MixinConstants.Annotations.SHADOW import com.demonwav.mcdev.platform.mixin.util.isMixin import com.intellij.codeInsight.intention.QuickFixFactory import com.intellij.codeInspection.ProblemsHolder import com.intellij.psi.JavaElementVisitor import com.intellij.psi.PsiElementVisitor import com.intellij.psi.PsiField import com.intellij.psi.PsiMember import com.intellij.psi.PsiMethod import com.intellij.psi.PsiModifier class StaticMemberInspection : MixinInspection() { override fun getStaticDescription() = "A mixin class does not exist at runtime, and thus having them public does not make sense. " + "Make the field/method private instead." override fun buildVisitor(holder: ProblemsHolder): PsiElementVisitor = Visitor(holder) private class Visitor(private val holder: ProblemsHolder) : JavaElementVisitor() { override fun visitMethod(method: PsiMethod) { visitMember(method) } override fun visitField(field: PsiField) { visitMember(field) } private fun visitMember(member: PsiMember) { if (isProblematic(member)) { holder.registerProblem( member, "Public static members are not allowed in Mixin classes", QuickFixFactory.getInstance().createModifierListFix(member, PsiModifier.PRIVATE, true, false), ) } } private fun isProblematic(member: PsiMember): Boolean { val containingClass = member.containingClass ?: return false if (!containingClass.isMixin) { return false } val modifiers = member.modifierList!! return modifiers.hasModifierProperty(PsiModifier.PUBLIC) && modifiers.hasModifierProperty(PsiModifier.STATIC) && modifiers.findAnnotation(SHADOW) == null && modifiers.findAnnotation(OVERWRITE) == null && modifiers.findAnnotation(ACCESSOR) == null && modifiers.findAnnotation(INVOKER) == null } } }

Add build comment

Mute test

Server communication failure

Run Custom Build

TODO

Responsibility

Edit tags

Loading...

Are you sure?