src/main/kotlin/platform/mixin/inspection/injector/CtorHeadNoUnsafeInspection.kt diff

← → edited src/main/kotlin/platform/mixin/inspection/injector/CtorHeadNoUnsafeInspection.kt

Ignore whitespaces Open in IDE

⁠ joe: Add inspections for unnecessary unsafe and CTOR_HEAD over HEAD

Copy Copy

/*
* Minecraft Development for IntelliJ
*
* https://mcdev.io/
*
* Copyright (C) 2024 minecraft-dev
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Lesser General Public License as published
* by the Free Software Foundation, version 3.0 only.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public License
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/

package com.demonwav.mcdev.platform.mixin.inspection.injector

import com.demonwav.mcdev.facet.MinecraftFacet
import com.demonwav.mcdev.platform.fabric.FabricModuleType
import com.demonwav.mcdev.platform.mixin.inspection.MixinInspection
import com.demonwav.mcdev.platform.mixin.util.MixinConstants
import com.demonwav.mcdev.util.constantStringValue
import com.demonwav.mcdev.util.constantValue
import com.demonwav.mcdev.util.findModule
import com.intellij.codeInspection.ProblemsHolder
import com.intellij.psi.JavaElementVisitor
import com.intellij.psi.PsiAnnotation
import com.intellij.psi.PsiElementVisitor
import java.awt.FlowLayout
import javax.swing.JCheckBox
import javax.swing.JComponent
import javax.swing.JPanel

class CtorHeadNoUnsafeInspection : MixinInspection() {
@JvmField
var ignoreForFabric = true

override fun createOptionsPanel(): JComponent {
val panel = JPanel(FlowLayout(FlowLayout.LEFT))
val checkbox = JCheckBox("Ignore in Fabric mods", ignoreForFabric)
checkbox.addActionListener {
ignoreForFabric = checkbox.isSelected
}
panel.add(checkbox)
return panel
}

override fun getStaticDescription() = "Reports when @At(\"CTOR_HEAD\") is missing unsafe"

override fun buildVisitor(holder: ProblemsHolder): PsiElementVisitor {
if (ignoreForFabric) {
val isFabric = holder.file.findModule()?.let { MinecraftFacet.getInstance(it) }?.isOfType(FabricModuleType)
?: false
if (isFabric) {
return PsiElementVisitor.EMPTY_VISITOR
}
}

return object : JavaElementVisitor() {
override fun visitAnnotation(annotation: PsiAnnotation) {
if (!annotation.hasQualifiedName(MixinConstants.Annotations.AT)) {
return
}
val valueElement = annotation.findDeclaredAttributeValue("value")
if (valueElement?.constantStringValue != "CTOR_HEAD") {
return
}
if (annotation.findDeclaredAttributeValue("unsafe")?.constantValue == true) {
return
}
holder.registerProblem(
valueElement,
"CTOR_HEAD is missing unsafe = true",
InjectIntoConstructorInspection.AddUnsafeFix(annotation),
)
}
}
}
}

/*
* Minecraft Development for IntelliJ
*
* https://mcdev.io/
*
* Copyright (C) 2024 minecraft-dev
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Lesser General Public License as published
* by the Free Software Foundation, version 3.0 only.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public License
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/

package com.demonwav.mcdev.platform.mixin.inspection.injector

import com.demonwav.mcdev.facet.MinecraftFacet
import com.demonwav.mcdev.platform.fabric.FabricModuleType
import com.demonwav.mcdev.platform.mixin.inspection.MixinInspection
import com.demonwav.mcdev.platform.mixin.inspection.fix.AnnotationAttributeFix
import com.demonwav.mcdev.platform.mixin.util.MixinConstants
import com.demonwav.mcdev.util.constantStringValue
import com.demonwav.mcdev.util.constantValue
import com.demonwav.mcdev.util.findModule
import com.intellij.codeInspection.ProblemsHolder
import com.intellij.psi.JavaElementVisitor
import com.intellij.psi.PsiAnnotation
import com.intellij.psi.PsiElementVisitor
import java.awt.FlowLayout
import javax.swing.JCheckBox
import javax.swing.JComponent
import javax.swing.JPanel

class CtorHeadNoUnsafeInspection : MixinInspection() {
@JvmField
var ignoreForFabric = true

override fun createOptionsPanel(): JComponent {
val panel = JPanel(FlowLayout(FlowLayout.LEFT))
val checkbox = JCheckBox("Ignore in Fabric mods", ignoreForFabric)
checkbox.addActionListener {
ignoreForFabric = checkbox.isSelected
}
panel.add(checkbox)
return panel
}

override fun getStaticDescription() = "Reports when @At(\"CTOR_HEAD\") is missing unsafe"

override fun buildVisitor(holder: ProblemsHolder): PsiElementVisitor {
if (ignoreForFabric) {
val isFabric = holder.file.findModule()?.let { MinecraftFacet.getInstance(it) }?.isOfType(FabricModuleType)
?: false
if (isFabric) {
return PsiElementVisitor.EMPTY_VISITOR
}
}

return object : JavaElementVisitor() {
override fun visitAnnotation(annotation: PsiAnnotation) {
if (!annotation.hasQualifiedName(MixinConstants.Annotations.AT)) {
return
}
val valueElement = annotation.findDeclaredAttributeValue("value")
if (valueElement?.constantStringValue != "CTOR_HEAD") {
return
}
if (annotation.findDeclaredAttributeValue("unsafe")?.constantValue == true) {
return
}
holder.registerProblem(
valueElement,
"CTOR_HEAD is missing unsafe = true",
AnnotationAttributeFix(annotation, "unsafe" to true),
)
}
}
}
}

/* * Minecraft Development for IntelliJ * * https://mcdev.io/ * * Copyright (C) 2024 minecraft-dev * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU Lesser General Public License as published * by the Free Software Foundation, version 3.0 only. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU Lesser General Public License * along with this program. If not, see <https://www.gnu.org/licenses/>. */ package com.demonwav.mcdev.platform.mixin.inspection.injector import com.demonwav.mcdev.facet.MinecraftFacet import com.demonwav.mcdev.platform.fabric.FabricModuleType import com.demonwav.mcdev.platform.mixin.inspection.MixinInspection import com.demonwav.mcdev.platform.mixin.util.MixinConstants import com.demonwav.mcdev.util.constantStringValue import com.demonwav.mcdev.util.constantValue import com.demonwav.mcdev.util.findModule import com.intellij.codeInspection.ProblemsHolder import com.intellij.psi.JavaElementVisitor import com.intellij.psi.PsiAnnotation import com.intellij.psi.PsiElementVisitor import java.awt.FlowLayout import javax.swing.JCheckBox import javax.swing.JComponent import javax.swing.JPanel class CtorHeadNoUnsafeInspection : MixinInspection() { @JvmField var ignoreForFabric = true override fun createOptionsPanel(): JComponent { val panel = JPanel(FlowLayout(FlowLayout.LEFT)) val checkbox = JCheckBox("Ignore in Fabric mods", ignoreForFabric) checkbox.addActionListener { ignoreForFabric = checkbox.isSelected } panel.add(checkbox) return panel } override fun getStaticDescription() = "Reports when @At(\"CTOR_HEAD\") is missing unsafe" override fun buildVisitor(holder: ProblemsHolder): PsiElementVisitor { if (ignoreForFabric) { val isFabric = holder.file.findModule()?.let { MinecraftFacet.getInstance(it) }?.isOfType(FabricModuleType) ?: false if (isFabric) { return PsiElementVisitor.EMPTY_VISITOR } } return object : JavaElementVisitor() { override fun visitAnnotation(annotation: PsiAnnotation) { if (!annotation.hasQualifiedName(MixinConstants.Annotations.AT)) { return } val valueElement = annotation.findDeclaredAttributeValue("value") if (valueElement?.constantStringValue != "CTOR_HEAD") { return } if (annotation.findDeclaredAttributeValue("unsafe")?.constantValue == true) { return } holder.registerProblem( valueElement, "CTOR_HEAD is missing unsafe = true", InjectIntoConstructorInspection.AddUnsafeFix(annotation), ) } } } } /* * Minecraft Development for IntelliJ * * https://mcdev.io/ * * Copyright (C) 2024 minecraft-dev * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU Lesser General Public License as published * by the Free Software Foundation, version 3.0 only. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU Lesser General Public License * along with this program. If not, see <https://www.gnu.org/licenses/>. */ package com.demonwav.mcdev.platform.mixin.inspection.injector import com.demonwav.mcdev.facet.MinecraftFacet import com.demonwav.mcdev.platform.fabric.FabricModuleType import com.demonwav.mcdev.platform.mixin.inspection.MixinInspection import com.demonwav.mcdev.platform.mixin.inspection.fix.AnnotationAttributeFix import com.demonwav.mcdev.platform.mixin.util.MixinConstants import com.demonwav.mcdev.util.constantStringValue import com.demonwav.mcdev.util.constantValue import com.demonwav.mcdev.util.findModule import com.intellij.codeInspection.ProblemsHolder import com.intellij.psi.JavaElementVisitor import com.intellij.psi.PsiAnnotation import com.intellij.psi.PsiElementVisitor import java.awt.FlowLayout import javax.swing.JCheckBox import javax.swing.JComponent import javax.swing.JPanel class CtorHeadNoUnsafeInspection : MixinInspection() { @JvmField var ignoreForFabric = true override fun createOptionsPanel(): JComponent { val panel = JPanel(FlowLayout(FlowLayout.LEFT)) val checkbox = JCheckBox("Ignore in Fabric mods", ignoreForFabric) checkbox.addActionListener { ignoreForFabric = checkbox.isSelected } panel.add(checkbox) return panel } override fun getStaticDescription() = "Reports when @At(\"CTOR_HEAD\") is missing unsafe" override fun buildVisitor(holder: ProblemsHolder): PsiElementVisitor { if (ignoreForFabric) { val isFabric = holder.file.findModule()?.let { MinecraftFacet.getInstance(it) }?.isOfType(FabricModuleType) ?: false if (isFabric) { return PsiElementVisitor.EMPTY_VISITOR } } return object : JavaElementVisitor() { override fun visitAnnotation(annotation: PsiAnnotation) { if (!annotation.hasQualifiedName(MixinConstants.Annotations.AT)) { return } val valueElement = annotation.findDeclaredAttributeValue("value") if (valueElement?.constantStringValue != "CTOR_HEAD") { return } if (annotation.findDeclaredAttributeValue("unsafe")?.constantValue == true) { return } holder.registerProblem( valueElement, "CTOR_HEAD is missing unsafe = true", AnnotationAttributeFix(annotation, "unsafe" to true), ) } } } }

Add build comment

Mute test

Server communication failure

Run custom build

TODO

Responsibility

Edit tags

Loading...

Are you sure?