Change details: kyle wood on 28 Mar 26 07:34

Comment:	Address lots of warnings and general code cleanup	Status:	all builds with this change have finished
Revision:	5c430ae035ca3bb1a9702d853cd2b53fc58e57c6	VCS Roots:	minecraft-dev/MinecraftDev (Git), minecraft-dev/MinecraftDev Nightly (Git)
Parent revisions:	9a4e5d33475a0466e4b26648df8eb34eb65d2fdb
User:	Unknown (none of TeamCity users defined kyle wood* username in their VCS username settings)*

Changed: 217 files (2 removed, 2 added, 213 edited) in

Download patch
Download patch to IDE
Open in GitHub

edited	buildSrc/src/main/kotlin/mcdev-core.gradle.kts
edited	gradle/libs.versions.toml
edited	src/main/kotlin/TranslationSettings.kt
edited	src/main/kotlin/asset/GeneralAssets.kt
edited	src/main/kotlin/creator/JdkComboBoxWithPreference.kt
edited	src/main/kotlin/creator/ProjectSetupFinalizerWizardStep.kt
edited	src/main/kotlin/creator/buildsystem/GradleFile.kt
edited	src/main/kotlin/creator/custom/BuiltinValidations.kt
edited	src/main/kotlin/creator/custom/CreatorCredentials.kt
edited	src/main/kotlin/creator/custom/CustomPlatformStep.kt
edited	src/main/kotlin/creator/custom/MavenRepoTable.kt
edited	src/main/kotlin/creator/custom/TemplateRepoTable.kt
edited	src/main/kotlin/creator/custom/derivation/ExtractPaperApiVersionPropertyDerivation.kt
edited	src/main/kotlin/creator/custom/derivation/RecommendJavaVersionForMcVersionPropertyDerivation.kt
edited	src/main/kotlin/creator/custom/derivation/SuggestClassNamePropertyDerivation.kt
edited	src/main/kotlin/creator/custom/finalizers/AddMavenRunConfigFinalizer.kt
edited	src/main/kotlin/creator/custom/finalizers/CreatorFinalizer.kt
edited	src/main/kotlin/creator/custom/finalizers/ImportGradleProjectFinalizer.kt
edited	src/main/kotlin/creator/custom/model/ClassFqn.kt
edited	src/main/kotlin/creator/custom/model/StringList.kt
edited	src/main/kotlin/creator/custom/providers/BuiltinTemplateProvider.kt
edited	src/main/kotlin/creator/custom/providers/EmptyLoadedTemplate.kt
edited	src/main/kotlin/creator/custom/providers/LocalTemplateProvider.kt
edited	src/main/kotlin/creator/custom/providers/RemoteTemplateProvider.kt
edited	src/main/kotlin/creator/custom/providers/TemplateProvider.kt
edited	src/main/kotlin/creator/custom/providers/VfsLoadedTemplate.kt
edited	src/main/kotlin/creator/custom/types/ArchitecturyVersionsCreatorProperty.kt
edited	src/main/kotlin/creator/custom/types/CreatorProperty.kt
edited	src/main/kotlin/creator/custom/types/MavenArtifactVersionCreatorProperty.kt
edited	src/main/kotlin/creator/custom/types/ParchmentCreatorProperty.kt
edited	src/main/kotlin/creator/step/LicenseStep.kt
edited	src/main/kotlin/creator/step/MainClassStep.kt
edited	src/main/kotlin/facet/LibraryPresentationProviders.kt
edited	src/main/kotlin/facet/MinecraftFacetDetector.kt
edited	src/main/kotlin/insight/ColorAnnotator.kt
edited	src/main/kotlin/insight/ColorPicker.kt
edited	src/main/kotlin/insight/InsightUtil.kt
edited	src/main/kotlin/insight/ListenerLineMarkerProvider.kt
edited	src/main/kotlin/insight/generation/EventGenHelper.kt
edited	src/main/kotlin/insight/generation/GenerateEventListenerHandler.kt
edited	src/main/kotlin/insight/generation/MethodRendererBasedEventListenerGenerationSupport.kt
edited	src/main/kotlin/insight/generation/MinecraftClassCreateAction.kt
edited	src/main/kotlin/insight/generation/ui/EventListenerWizard.kt
edited	src/main/kotlin/inspection/WrongEntityDataParameterClassInspection.kt
edited	src/main/kotlin/nbt/editor/NbtFileEditorProvider.kt
edited	src/main/kotlin/nbt/lang/NbttLanguage.kt
edited	src/main/kotlin/nbt/lang/NbttParserDefinition.kt
edited	src/main/kotlin/nbt/lang/colors/NbttColorSettingsPage.kt
edited	src/main/kotlin/nbt/lang/format/NbttBlock.kt
edited	src/main/kotlin/nbt/lang/format/NbttFormattingModelBuilder.kt
edited	src/main/kotlin/nbt/tags/NbtTag.kt
edited	src/main/kotlin/nbt/tags/NbtTypeId.kt
edited	src/main/kotlin/nbt/tags/TagList.kt
removed	src/main/kotlin/platform/BaseTemplate.kt
removed	src/main/kotlin/platform/bukkit/BukkitLikeConfiguration.kt
edited	src/main/kotlin/platform/bukkit/BukkitModule.kt
edited	src/main/kotlin/platform/bukkit/creator/asset-steps.kt
edited	src/main/kotlin/platform/bukkit/creator/maven-steps.kt
edited	src/main/kotlin/platform/bukkit/creator/ui-steps.kt
edited	src/main/kotlin/platform/bungeecord/BungeeCordModule.kt
edited	src/main/kotlin/platform/bungeecord/creator/asset-steps.kt
edited	src/main/kotlin/platform/bungeecord/creator/maven-steps.kt
edited	src/main/kotlin/platform/fabric/creator/ui-steps.kt
edited	src/main/kotlin/platform/fabric/inspection/FabricEntrypointsInspection.kt
edited	src/main/kotlin/platform/fabric/util/FabricConstants.kt
edited	src/main/kotlin/platform/forge/ForgeModule.kt
edited	src/main/kotlin/platform/forge/gradle/ForgeRunConfigDataService.kt
edited	src/main/kotlin/platform/forge/inspections/sideonly/SideOnlyUtil.kt
edited	src/main/kotlin/platform/forge/inspections/sideonly/SidedProxyAnnotator.kt
edited	src/main/kotlin/platform/forge/util/ForgeConstants.kt
edited	src/main/kotlin/platform/mcp/actions/CopyAwAction.kt
edited	src/main/kotlin/platform/mcp/actions/GotoAtEntryAction.kt
edited	src/main/kotlin/platform/mcp/actions/SrgActionBase.kt
edited	src/main/kotlin/platform/mcp/at/AtColorSettingsPage.kt
edited	src/main/kotlin/platform/mcp/at/AtElementFactory.kt
edited	src/main/kotlin/platform/mcp/at/AtFileType.kt
edited	src/main/kotlin/platform/mcp/at/AtLanguage.kt
edited	src/main/kotlin/platform/mcp/at/AtParserDefinition.kt
edited	src/main/kotlin/platform/mcp/at/completion/AtCompletionContributor.kt
edited	src/main/kotlin/platform/mcp/ct/CtAnnotator.kt
edited	src/main/kotlin/platform/mcp/ct/CtColorSettingsPage.kt
edited	src/main/kotlin/platform/mcp/ct/CtCompletionContributor.kt
edited	src/main/kotlin/platform/mcp/ct/CtFileType.kt
edited	src/main/kotlin/platform/mcp/ct/CtLanguage.kt
edited	src/main/kotlin/platform/mcp/ct/CtParserDefinition.kt
edited	src/main/kotlin/platform/mcp/ct/fixes/CopyAwAccessibleEntryFix.kt
edited	src/main/kotlin/platform/mcp/ct/psi/mixins/CtEntryMixin.kt
edited	src/main/kotlin/platform/mcp/ct/psi/mixins/CtItfEntryMixin.kt
edited	src/main/kotlin/platform/mcp/ct/psi/mixins/impl/CtEntryImplMixin.kt
edited	src/main/kotlin/platform/mcp/ct/psi/mixins/impl/CtItfEntryImplMixin.kt
edited	src/main/kotlin/platform/mcp/fabricloom/FabricLoomDataService.kt
edited	src/main/kotlin/platform/mcp/fabricloom/FabricLoomDecompileSourceProvider.kt
edited	src/main/kotlin/platform/mcp/fabricloom/TinyUnscrambler.kt
edited	src/main/kotlin/platform/mcp/gradle/McpProjectResolverExtension.kt
edited	src/main/kotlin/platform/mcp/mappings/Mappings.kt
edited	src/main/kotlin/platform/mcp/vanillagradle/VanillaGradleDecompileSourceProvider.kt
edited	src/main/kotlin/platform/mixin/action/FindMixinsAction.kt
edited	src/main/kotlin/platform/mixin/action/GenerateAccessorHandler.kt
edited	src/main/kotlin/platform/mixin/action/GenerateSoftImplementsAction.kt
edited	src/main/kotlin/platform/mixin/completion/MixinLookupItem.kt
edited	src/main/kotlin/platform/mixin/config/MixinConfig.kt
edited	src/main/kotlin/platform/mixin/config/MixinConfigFileType.kt
edited	src/main/kotlin/platform/mixin/config/inspection/ConfigValueInspection.kt
edited	src/main/kotlin/platform/mixin/expression/MEExpressionBraceMatcher.kt
edited	src/main/kotlin/platform/mixin/expression/MEExpressionColorSettingsPage.kt
edited	src/main/kotlin/platform/mixin/expression/MEExpressionCompletionUtil.kt
edited	src/main/kotlin/platform/mixin/expression/MEExpressionInjector.kt
edited	src/main/kotlin/platform/mixin/expression/MEExpressionLanguage.kt
edited	src/main/kotlin/platform/mixin/expression/gui/FlowDiagram.kt
edited	src/main/kotlin/platform/mixin/expression/gui/FlowGraph.kt
edited	src/main/kotlin/platform/mixin/expression/psi/mixins/impl/MECastExpressionImplMixin.kt
edited	src/main/kotlin/platform/mixin/expression/psi/mixins/impl/MEDeclarationImplMixin.kt
edited	src/main/kotlin/platform/mixin/folding/AccessorMixinFoldingBuilder.kt
edited	src/main/kotlin/platform/mixin/handlers/AccessorHandler.kt
edited	src/main/kotlin/platform/mixin/handlers/InjectorAnnotationHandler.kt
edited	src/main/kotlin/platform/mixin/handlers/InvokerHandler.kt
edited	src/main/kotlin/platform/mixin/handlers/ModifyConstantHandler.kt
edited	src/main/kotlin/platform/mixin/handlers/ModifyVariableHandler.kt
edited	src/main/kotlin/platform/mixin/handlers/RedirectInjectorHandler.kt
edited	src/main/kotlin/platform/mixin/handlers/ShadowHandler.kt
edited	src/main/kotlin/platform/mixin/handlers/injectionPoint/AtResolver.kt
edited	src/main/kotlin/platform/mixin/handlers/injectionPoint/ConstantInjectionPoint.kt
edited	src/main/kotlin/platform/mixin/handlers/injectionPoint/ConstantStringMethodInjectionPoint.kt
edited	src/main/kotlin/platform/mixin/handlers/injectionPoint/CtorHeadInjectionPoint.kt
edited	src/main/kotlin/platform/mixin/handlers/injectionPoint/FieldInjectionPoint.kt
edited	src/main/kotlin/platform/mixin/handlers/injectionPoint/InvokeAssignInjectionPoint.kt
edited	src/main/kotlin/platform/mixin/handlers/injectionPoint/JumpInjectionPoint.kt
edited	src/main/kotlin/platform/mixin/handlers/injectionPoint/NewInsnInjectionPoint.kt
edited	src/main/kotlin/platform/mixin/handlers/mixinextras/MixinExtrasInjectorAnnotationHandler.kt
edited	src/main/kotlin/platform/mixin/insight/target/AccessorTargetCodeVisionProvider.kt
edited	src/main/kotlin/platform/mixin/insight/target/MixinAccessorTargetLineMarkerProvider.kt
edited	src/main/kotlin/platform/mixin/insight/target/MixinTargetCodeVisionProvider.kt
edited	src/main/kotlin/platform/mixin/insight/target/MixinTargetLineMarkerProvider.kt
edited	src/main/kotlin/platform/mixin/inspection/MixinClassTypeInspection.kt
edited	src/main/kotlin/platform/mixin/inspection/UnusedMixinInspection.kt
edited	src/main/kotlin/platform/mixin/inspection/addedMembers/AddedMembersNameFormatInspection.kt
edited	src/main/kotlin/platform/mixin/inspection/fix/AnnotationAttributeFix.kt
edited	src/main/kotlin/platform/mixin/inspection/injector/CancellableBeforeSuperCallInspection.kt
edited	src/main/kotlin/platform/mixin/inspection/injector/CtorHeadUsedForNonConstructorInspection.kt
edited	src/main/kotlin/platform/mixin/inspection/injector/InjectCouldBeOverwriteInspection.kt
edited	src/main/kotlin/platform/mixin/inspection/injector/InjectIntoConstructorInspection.kt
edited	src/main/kotlin/platform/mixin/inspection/injector/InvalidInjectorMethodSignatureInspection.kt
edited	src/main/kotlin/platform/mixin/inspection/injector/MixinCancellableInspection.kt
edited	src/main/kotlin/platform/mixin/inspection/injector/MixinParameterNameInspection.kt
edited	src/main/kotlin/platform/mixin/inspection/injector/ModifyVariableArgsOnlyInspection.kt
edited	src/main/kotlin/platform/mixin/inspection/injector/ModifyVariableMayUseNameInspection.kt
edited	src/main/kotlin/platform/mixin/inspection/injector/UnnecessaryUnsafeInspection.kt
edited	src/main/kotlin/platform/mixin/inspection/injector/UnusedLocalCaptureInspection.kt
edited	src/main/kotlin/platform/mixin/inspection/mixinextras/InjectLocalCaptureReplaceWithLocalInspection.kt
edited	src/main/kotlin/platform/mixin/inspection/mixinextras/InvokeAssignReplaceWithExpressionInspection.kt
edited	src/main/kotlin/platform/mixin/inspection/mixinextras/LocalArgsOnlyInspection.kt
edited	src/main/kotlin/platform/mixin/inspection/mixinextras/LocalMayUseNameInspection.kt
edited	src/main/kotlin/platform/mixin/inspection/mixinextras/WrapWithConditionValidNonVoidInspection.kt
edited	src/main/kotlin/platform/mixin/inspection/reference/UnnecessaryQualifiedMemberReferenceInspection.kt
edited	src/main/kotlin/platform/mixin/inspection/suppress/DefaultAnnotationParamInspectionSuppressor.kt
edited	src/main/kotlin/platform/mixin/inspection/suppress/MixinClassCastInspectionSuppressor.kt
edited	src/main/kotlin/platform/mixin/inspection/suppress/ShadowOverwriteInspectionSuppressor.kt
edited	src/main/kotlin/platform/mixin/inspection/suppress/StaticInvokerUnusedParamInspectionSuppressor.kt
edited	src/main/kotlin/platform/mixin/reference/AbstractMethodReference.kt
edited	src/main/kotlin/platform/mixin/reference/DescReference.kt
edited	src/main/kotlin/platform/mixin/reference/MixinReferenceContributor.kt
edited	src/main/kotlin/platform/mixin/reference/MixinSelectors.kt
edited	src/main/kotlin/platform/mixin/reference/target/DefinitionReferences.kt
edited	src/main/kotlin/platform/mixin/util/AsmDfaUtil.kt
edited	src/main/kotlin/platform/mixin/util/AsmUtil.kt
edited	src/main/kotlin/platform/mixin/util/LocalVariables.kt
edited	src/main/kotlin/platform/mixin/util/Mixin.kt
edited	src/main/kotlin/platform/mixin/util/MixinConstants.kt
edited	src/main/kotlin/platform/neoforge/NeoForgeModule.kt
edited	src/main/kotlin/platform/neoforge/gradle/NeoForgeRunConfigDataService.kt
edited	src/main/kotlin/platform/sponge/SpongeVersion.kt
edited	src/main/kotlin/platform/sponge/color/SpongeColorAnnotator.kt
edited	src/main/kotlin/platform/sponge/creator/maven-steps.kt
edited	src/main/kotlin/platform/sponge/inspection/SpongeInjectionInspection.kt
edited	src/main/kotlin/platform/sponge/util/Events.kt
edited	src/main/kotlin/platform/velocity/VelocityModule.kt
edited	src/main/kotlin/toml/platform/forge/ModsTomlDocumentationProvider.kt
edited	src/main/kotlin/toml/platform/forge/inspections/ModsTomlValidationInspection.kt
edited	src/main/kotlin/toml/platform/forge/reference/ModsTomlReferenceContributor.kt
edited	src/main/kotlin/translations/TranslationEditorNotificationProvider.kt
edited	src/main/kotlin/translations/TranslationFiles.kt
edited	src/main/kotlin/translations/actions/SortTranslationsAction.kt
edited	src/main/kotlin/translations/actions/TranslationSortOrderDialog.kt
edited	src/main/kotlin/translations/identification/TranslationIdentifier.kt
edited	src/main/kotlin/translations/index/TranslationIndex.kt
edited	src/main/kotlin/translations/index/TranslationInverseIndex.kt
edited	src/main/kotlin/translations/index/providers.kt
edited	src/main/kotlin/translations/intentions/ConvertToTranslationIntention.kt
edited	src/main/kotlin/translations/intentions/RemoveDuplicatesIntention.kt
edited	src/main/kotlin/translations/intentions/TranslationFileAnnotator.kt
edited	src/main/kotlin/translations/lang/LangParserDefinition.kt
edited	src/main/kotlin/translations/lang/MCLangLanguage.kt
edited	src/main/kotlin/translations/lang/colors/LangColorSettingsPage.kt
edited	src/main/kotlin/translations/lang/psi/mixins/LangEntryMixin.kt
edited	src/main/kotlin/translations/reference/TranslationGotoSymbolContributor.kt
edited	src/main/kotlin/translations/reference/TranslationReference.kt
edited	src/main/kotlin/translations/reference/completion.kt
edited	src/main/kotlin/translations/sorting/TranslationSorter.kt
edited	src/main/kotlin/translations/sorting/TranslationTemplateConfigurable.kt
edited	src/main/kotlin/update/ConfigurePluginUpdatesDialog.kt
edited	src/main/kotlin/util/CommonColors.kt
edited	src/main/kotlin/util/License.kt
edited	src/main/kotlin/util/MinecraftTemplates.kt
edited	src/main/kotlin/util/annotation-utils.kt
edited	src/main/kotlin/util/psi-utils.kt
edited	src/main/kotlin/util/utils.kt
edited	src/main/kotlin/yaml/PluginYmlInspection.kt
edited	src/main/resources/META-INF/plugin.xml
added	src/main/resources/inspectionDescriptions/CleanupJoinDeclarationAndAssignment.html
added	src/main/resources/inspectionDescriptions/CleanupUnnecessaryLocalVariable.html
edited	src/main/resources/messages/MinecraftDevelopment.properties
edited	src/test/resources/com/demonwav/mcdev/platform/mcp/at/parser/fixtures/asterisks_at.txt
edited	src/test/resources/com/demonwav/mcdev/platform/mcp/at/parser/fixtures/comments_at.txt
edited	src/test/resources/com/demonwav/mcdev/platform/mcp/at/parser/fixtures/fields_at.txt
edited	src/test/resources/com/demonwav/mcdev/platform/mcp/at/parser/fixtures/funcs_at.txt
edited	src/test/resources/com/demonwav/mcdev/platform/mcp/at/parser/fixtures/keywords_at.txt
edited	src/test/resources/com/demonwav/mcdev/platform/mcp/at/parser/fixtures/no_value_at.txt

Edit change description

Add build comment

Mute test

Server communication failure

Run custom build

TODO

Responsibility

Edit tags

Loading...

Are you sure?